[codex] publish fbuild usb vidpid overlay#907
Draft
zackees wants to merge 3 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zackees
force-pushed
the
codex/usb-vid-proto-online-data
branch
18 times, most recently
from
e86690f to
cb0c99c
Compare
zackees
force-pushed
the
codex/usb-vid-proto-online-data
branch
9 times, most recently
from
02acb32 to
5bc737f
Compare
zackees
force-pushed
the
codex/usb-vid-proto-online-data
branch
19 times, most recently
from
ce74c01 to
7d334d8
Compare
zackees
force-pushed
the
codex/usb-vid-proto-online-data
branch
from
7d334d8 to
40d9c9e
Compare
Move the proto-first / JSON-fallback overlay download + install helper into
`fbuild_core::usb::populate_online_cache_from_paths(_and_urls)` so both
`fbuild port scan` and daemon-backed device paths share the same cold-cache
hydration path. The helper still runs the reqwest blocking client on a
dedicated OS thread (safe from Tokio) and uses the shared
`fbuild_core::http::blocking_client` bridge.
`fbuild-cli` now delegates to the shared helper; the local
fetch/cache-freshness scaffolding is deleted and the port_scan test that
exercised the local helper is replaced by a proto-404-then-JSON-200
integration test (kept in the CLI crate) plus a new
`populate_online_cache_falls_back_to_json_when_proto_is_missing` test
in `fbuild-core::usb::data`.
`fbuild-daemon` startup now spawn_blocking's a best-effort call to
`populate_online_cache_from_paths` using `<cache-root>/usb/{usb-vids.proto.zstd,
usb-vid.json}` before device refresh/list can be served, so
`fbuild device list/status/deploy` return full vendor + product names
instead of tier-1 vendor-only + `Device 0xPPPP` placeholder. Any failure
logs at debug/warn and never blocks daemon bootstrap.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
online-data-tools/build_usb_vid_proto.pyto encode mergedusb-vid.jsoninto theusb-vids.proto.zstdprotobuf/zstd runtime artifact thatfbuild_core::usbalready knows how to read.Update datato publishdata/usb-vids.proto.zstdon theonline-databranch whenever the USB merge succeeds.USB_VIDS_PROTO_ZSTD_URLfromfastled.github.io/boardsto the fbuildonline-databranch.fbuild port scan, daemonDeviceState, device list/status API responses, and CLIfbuild deviceoutput.Why
The runtime scan path was fetching a compact VID/PID overlay from
fastled.github.io/boards, while this repo'sonline-dataworkflow only published JSON/SQLite/vendor artifacts. That left fbuild dependent on an external board artifact for product-level VID/PID resolution. This makes fbuild publish and consume its own compact artifact.The device surfaces also exposed vendor/product but not the requested CDC-vs-bridge signal. The new nullable
is_cdcfield reportstruefor CDC ACM,falsefor USB serial bridge, andnullwhen the host cannot classify the port.Follow-up note
First-party repo board data remains the support boundary: if a board is not present under
crates/fbuild-config/assets/boards, it may not exist as an fbuild-supported board. Remaining product-PID gaps should be researched from internet/vendor sources only for boards that are present in that repo board set; third-party SDK/package findings can weakly fill missing VID/PID names but must not override first-party, vendor-owned, or generic USB-ID winners.Validation
uv run --no-project --with pytest --with zstandard pytest online-data-tools/test_usb_vid_proto.py -qsoldr cargo test -p fbuild-core usb::data --libsoldr cargo test -p fbuild-cli port_scan --libsoldr cargo test -p fbuild-cli cdc_suffix --libsoldr cargo test -p fbuild-daemon device_manager --libsoldr cargo test -p fbuild-daemon deploy_port --libsoldr cargo test -p fbuild-cli --libsoldr cargo test -p fbuild-daemon --libsoldr cargo test -p fbuild-serial --libsoldr cargo test -p fbuild-packages --libsoldr cargo clippy -p fbuild-serial --all-targets -- -D warningssoldr cargo clippy -p fbuild-build --tests -- -D warningssoldr cargo doc -p fbuild-build --no-depswithRUSTDOCFLAGS=-D warningssoldr cargo doc -p fbuild-cli --no-depswithRUSTDOCFLAGS=-D warningsdocker run --rm -v "${PWD}:/work" -w /work rust:1.94.1 bash -lc "export PATH=/usr/local/cargo/bin:$PATH; cargo fmt --all -- --check"uv run --no-project python ci/render_workflows.py --checkuv run --no-project python -m py_compile ci/validate_boards.pygit diff --checkAlso generated the artifact from the current published
usb-vid.json: 1,946 vendors, 22,258 products, 260,305-byteusb-vids.proto.zstd.